Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: custom home page with setting logoLink leads to 404 page #3271

Closed
wants to merge 3 commits into from
Closed

fix: custom home page with setting logoLink leads to 404 page #3271

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d60c29f
fix: custom home page with setting logoLink leads to 404 page
zonemeen Nov 29, 2023
1c9f98a
refactor
zonemeen Nov 30, 2023
0d52648
refactor
zonemeen Nov 30, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
7 changes: 7 additions & 0 deletions src/client/app/router.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -181,6 +181,13 @@ export function createRouter(
: link.href,
link.baseURI
)

// temporary fix for #3264
if (
siteDataRef.value.themeConfig?.logoLink === href.replace(/\/$/, '')
)
return

const currentUrl = window.location
const mimeType = lookup(pathname)
// only intercept inbound links
Expand Down