feat(theme): new design for local nav and global header #3359
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Some transition duration is wrong. Try resizing browser window to lower height and scroll the home page up and down. The logo-side divider seems to have no transition. |
|
@brc-dd |
|
z-index issue? 
|
|
Oh no... thanks for spotting. Yeah the z-index is a bit of mess. I'll stop being lazy and reorganize them. |
|
@brc-dd |
|
LGTM. I'll make some changes to handle body scroll and closing on esc/click outside. |
brc-dd
force-pushed
the
new-local-nav
branch
from
214483e
to
28a27a3
Compare
brc-dd
force-pushed
the
new-local-nav
branch
from
2ba88d5
to
b137914
Compare
4 tasks
4 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A new styles for outline dropdown on tablet viewport. This PR also adds new composable
useLocalNavto check if the local nav is there.This removes the blurred header "curtain" and simply adds divider between header and the content.