feat: support GitHub-flavored alerts #3482
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brc-dd
reviewed
Jan 20, 2024
|
It can be another PR, but do you think we should add icons to those callouts and make it configurable like |
brc-dd
approved these changes
Jan 21, 2024
In one PR Guillaume attempted adding it via CSS icons. We can do that probably and instead of making it configurable via config, better to just allow overriding the icon variables in custom CSS? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #3278
Added three variants:
NOTE(Same asINFO)CAUTION(Same asDANGER)IMPORTANT(with a new purple color).