Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

accessibility: interactive controls should not be nested #3517

Open
4 tasks done
gorlanova opened this issue Jan 29, 2024 · 0 comments · May be fixed by #3806
Open
4 tasks done

accessibility: interactive controls should not be nested #3517

gorlanova opened this issue Jan 29, 2024 · 0 comments · May be fixed by #3806
Labels
a11y Related to accessibility stale theme Related to the theme

Comments

@gorlanova
Copy link

Describe the bug

in the collapsible navigation sidebar, group header interactive controls are nested, this is inaccessible for some accessibility tools as the nested button will not always be announced

Reproduction

set a collapsible nav in the sidebar
inspect the tree : the nav group header is "tabindex = 0" and contains a button

Expected behavior

either the header should not have a tabindex, or the header button should simply be an icon (no need for two buttons doing the same thing ?)

System Info

System:
    OS: macOS 14.2.1
    CPU: (8) arm64 Apple M2
    Memory: 393.92 MB / 24.00 GB
    Shell: 5.9 - /bin/zsh
  Binaries:
    Node: 20.10.0 - /usr/local/bin/node
    Yarn: 1.22.19 - /opt/homebrew/bin/yarn
    npm: 10.2.5 - /usr/local/bin/npm
    pnpm: 8.9.2 - /opt/homebrew/bin/pnpm
  Browsers:
    Safari: 17.2.1
  npmPackages:
    vitepress: ^1.0.0-rc.31 => 1.0.0-rc.35

Additional context

Screenshot 2024-01-29 at 15 55 59

Validations

@gorlanova gorlanova added the bug: pending triage Maybe a bug, waiting for confirmation label Jan 29, 2024
@brc-dd brc-dd added theme Related to the theme a11y Related to accessibility and removed bug: pending triage Maybe a bug, waiting for confirmation labels Jan 30, 2024
@github-actions github-actions bot added the stale label Mar 7, 2024
olets added a commit to olets/vitepress that referenced this issue Apr 18, 2024
Makes sidebar item group toggle's caret not focusable.
Clicking on caret still toggles the group.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a11y Related to accessibility stale theme Related to the theme
Projects
None yet
2 participants