Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Inter font family to version 4 #3693

Closed
4 tasks done
GabsEdits opened this issue Mar 23, 2024 · 4 comments · Fixed by #3694
Closed
4 tasks done

Update Inter font family to version 4 #3693

GabsEdits opened this issue Mar 23, 2024 · 4 comments · Fixed by #3694
Labels
contribution welcome The team would welcome a contribution from the community for this issue enhancement New feature or request theme Related to the theme

Comments

@GabsEdits
Copy link
Contributor

Is your feature request related to a problem? Please describe.

It would be nice to have the latest version of Inter for VitePress

Describe the solution you'd like

I'd love if the woff files of the font would be update it to the latest version (4). The last change to those files were 2 years ago, way before version 4.

Describe alternatives you've considered

No response

Additional context

No response

Validations

@brc-dd brc-dd added enhancement New feature or request theme Related to the theme contribution welcome The team would welcome a contribution from the community for this issue labels Mar 23, 2024
@GabsEdits
Copy link
Contributor Author

The placement of font files has changed now 🤔 . I've examined the inter-ui NPM package, and the same can be accomplished here by duplicating the CSS files and two variable 'woff2' files.

@brc-dd
Copy link
Member

brc-dd commented Mar 23, 2024

Ah no it's bit more complex than that. You'll need something like pyftsubset to create those subsets. Your PR will load those 700KB files even when it needs only 40KB.

@GabsEdits
Copy link
Contributor Author

Ah no it's bit more complex than that. You'll need something like pyftsubset to create those subsets. Your PR will load those 700KB files even when it needs only 40KB.

Ah, I get it, I will look into it soon. Thanks!

@GabsEdits
Copy link
Contributor Author

I've updated the Pull request to now include Font Subsets. @brc-dd I'd love your review 👍

brc-dd added a commit that referenced this issue Apr 2, 2024
Co-authored-by: Divyansh Singh <40380293+brc-dd@users.noreply.github.com>
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 28, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
contribution welcome The team would welcome a contribution from the community for this issue enhancement New feature or request theme Related to the theme
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants