Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Chinese file link build failed (#424) #425

Merged
merged 1 commit into from
Jan 6, 2022
Merged

Conversation

fuchunhui
Copy link
Contributor

No description provided.

@yyx990803 yyx990803 merged commit ae029ae into vuejs:main Jan 6, 2022
@Xu-pixel
Copy link

but in v0.22.3, it is still not work.
image

@fuchunhui
Copy link
Contributor Author

fuchunhui commented Apr 25, 2022

Just tried this and didn't reproduce your problem. you can try here
I guess that the possible reason is the path problem of your file.

Here are some tips:

  • Ask questions needed in the issue area.
  • Provide to a demo that can be reproduced so that others can help you solve it more quickly.
  • More detailed description of the problem, step by step.

Demo for you.
image

image

@Xu-pixel
Copy link

Thank you for your reply.It can work well in dev environment but error in build.

I downloaded your project and used yarn docs:build:
image

@fuchunhui
Copy link
Contributor Author

right, I get it.
same with #293

rollup/ModuleLoader.ts#L541

// before
await this.resolveId(source, module.id, EMPTY_OBJECT, false)

// after
await this.resolveId(decodeURIComponent(source), module.id, EMPTY_OBJECT, false)

this works, but I don't know how to solve it in vitepress.

@Xu-pixel
Copy link

Thank you !

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants