refactor: remove non-standard markdown-it extensions #1240
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brc-dd
approved these changes
Aug 26, 2022
4 tasks
|
This broke current vuejs.org builds! Please do not make risky changes like this in the future. These internal stuff exist for a reason. |
|
@yyx990803 Sorry for that. Using env of markdown-it should be a more recommended way for passing md render context. @brc-dd We should also review the usage in vue/theme, too. |
|
Should we create a PR for https://github.com/vuejs/docs repo? I saw the legacy usage in that repo. @yyx990803 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.