Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add ability to configure markdown options (#127) #128

Merged
merged 5 commits into from
Nov 18, 2020

Conversation

ChrisShank
Copy link
Contributor

@ChrisShank ChrisShank commented Nov 17, 2020

close #127

As a side note, I have not been able to test this PR locally. I am getting multiple runtime errors in my test vitepress site. Any guidance would be appreciated. 😃

image

@kiaking kiaking added the enhancement New feature or request label Nov 17, 2020
@kiaking
Copy link
Member

kiaking commented Nov 17, 2020

@ChrisShank I've fixed the issue and pushed it. Could you try it on your side if you still get any errors?

@kiaking kiaking changed the title feat(user-markdown-options): add ability to configure markdown options feat: add ability to configure markdown options (#127) Nov 17, 2020
@ChrisShank
Copy link
Contributor Author

ChrisShank commented Nov 18, 2020

@kiaking Just tested and this is looking good, I appreciate the help!!

@kiaking
Copy link
Member

kiaking commented Nov 18, 2020

Thank you so much for the confirmation 🙌

@kiaking kiaking merged commit 463a03a into vuejs:master Nov 18, 2020
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Configure markdown options
2 participants