feat: Line Numbers only for single code block #1363
Conversation
Signed-off-by: GurkiranSingh <gurkiransinghk@gmail.com>
Signed-off-by: GurkiranSingh <gurkiransinghk@gmail.com>
| const fence = md.renderer.rules.fence! | ||
| md.renderer.rules.fence = (...args) => { | ||
| const rawCode = fence(...args) | ||
| const [tokens, idx] = args | ||
| const token = tokens[idx] | ||
| const attr = token.attrs && token.attrs[0] |
There was a problem hiding this comment.
This logic won't work if markdown-it-attrs is disabled. As a fallback, you need to manually check token.info too for that option (refer highlightLines plugin for example, we had done similar stuff there). Also, have you checked if this works with line highlighting and snippets import? If yes, then consider adding some example to the docs.
There was a problem hiding this comment.
@brc-dd On disabling markdown-it-attrs, I noticed that on the top right corner of code block where we are displaying the language for the code, the {1,4,6-8} - line highlightning syntax is also coming up. Is this intended or a bug ?
There was a problem hiding this comment.
I have resolved the above bug and also line numbers are now working even if markdown-it-attrs is disabled. Please, let me know if you see any issues :)
…ne numbers are compatible even when markdown-it-attrs is disabled. Also, added example of line numbers code block with line highlightning Signed-off-by: GurkiranSingh <gurkiransinghk@gmail.com>
Signed-off-by: GurkiranSingh <gurkiransinghk@gmail.com>
Signed-off-by: GurkiranSingh gurkiransinghk@gmail.com
feat: Line Numbers only for single code block
{showLineNumbers}then it will show line numbers for that particular code blockPlease, let me know if you see any issues :)