Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Document support image preview #1504

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

Jimmylxue
Copy link
Contributor

@Jimmylxue Jimmylxue commented Oct 18, 2022

About PR

Thanks for checking

We often insert pictures in documents,But currently does not support preview images, so i add this feature on this pr.

Please forgive me and give pointers if there is any bad writing.

we can preview like this:

Operation Video

demo

As long as img is used in the document, clicking on this image can trigger the preview effect, like this:

![image-20220103230652865](https://vitepress-source.oss-cn-beijing.aliyuncs.com/typoraimage-20220103230652865.png)

![An image](/assets/bg.jpg)

Thanks again

@kiaking kiaking added enhancement New feature or request theme Related to the theme labels Oct 20, 2022
@kiaking
Copy link
Member

kiaking commented Oct 20, 2022

Could be nice feature to add, but I would like to adjust the stylings a bit. I'll look into it when I get time!

@kiaking kiaking self-assigned this Oct 20, 2022
@brc-dd
Copy link
Member

brc-dd commented Oct 20, 2022

Also, there was some discussion on this. Refer #854, it is straightforward to add if someone wants (the example is outdated though 😅, #854 (comment) will fix route change issues).

@Jimmylxue
Copy link
Contributor Author

would
thanks, I am looking forward to updating as soon as possible!

@Charles7c
Copy link
Contributor

Is there still a chance for this feature?

@github-actions github-actions bot added the stale label Feb 2, 2024
@github-actions github-actions bot removed the stale label Apr 28, 2024
@github-actions github-actions bot added the stale label Jun 9, 2024
@github-actions github-actions bot removed the stale label Jul 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request theme Related to the theme
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants