Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: offline search #2110

Merged
merged 35 commits into from Apr 11, 2023
Merged

feat: offline search #2110

merged 35 commits into from Apr 11, 2023

Conversation

Akryum
Copy link
Member

@Akryum Akryum commented Mar 20, 2023 •
edited

Fix #670

  • Generate index during dev
  • Generate index during build
  • Update index on file change
  • Search UI
  • Keyboard shortcuts
  • Translatable help text
  • Match highlighting
  • Mobile UI
  • Dynamic routing
  • UI Localization
  • Filter by locale
  • Documentation

image

@Akryum
Copy link
Member Author

Akryum commented Mar 21, 2023

@brc-dd Maybe we can implement search for dynamic routes later?

@brc-dd
Copy link
Member

brc-dd commented Mar 21, 2023

Yeah, fine by me.

@brc-dd
Copy link
Member

brc-dd commented Mar 21, 2023

Another thing, does it filter results based on the current locale?

@Akryum
Copy link
Member Author

Akryum commented Mar 21, 2023

Another thing, does it filter results based on the current locale?

Working on it!

@Akryum
Copy link
Member Author

Akryum commented Mar 21, 2023

image
image

@Akryum Akryum marked this pull request as ready for review March 21, 2023 16:14
@brc-dd brc-dd self-requested a review March 23, 2023 04:17
Akryum and others added 2 commits March 28, 2023 12:08
@Akryum @chgeo
fix: route rewrites and duplicate slash
6cca13f 
Co-authored-by: Christian Georgi <chgeo@users.noreply.github.com>
@Akryum
lint: fix
4e0a0db
brc-dd
brc-dd reviewed Mar 29, 2023
View reviewed changes
package.json Outdated Show resolved Hide resolved
@brc-dd
Copy link
Member

brc-dd commented Mar 29, 2023 •
edited

rest of the stuff looks fine to me 🚀

/cc @kiaking might have some design related suggestions?

@JohnCampionJr
Copy link
Contributor

JohnCampionJr commented Apr 4, 2023 •
edited

This is fantastic work! Any chance we can get this merged soon? :)

@brc-dd brc-dd merged commit 6c92675 into vuejs:main Apr 11, 2023
7 checks passed
@stefnotch stefnotch mentioned this pull request Apr 11, 2023
Open
@Stuyk Stuyk mentioned this pull request Apr 11, 2023
Closed
@Akryum Akryum deleted the feat/offline-search branch April 11, 2023 13:57
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@chgeo chgeo chgeo left review comments

@brc-dd brc-dd brc-dd left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Offline search functionality
4 participants
@Akryum @brc-dd @JohnCampionJr @chgeo