feat: allow configuring light theme codeblocks #2200
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I need to check some weird behavior in code copy styles, the left block sometimes scrolls 1 or 2 pixels up.
Right now, this PR using
github-light
Shiki theme for light theme.There are 3 TODO we should review:
node/config.ts
: we also need to handle when configuring only 1 appareancedocs/reference/site-config.md
: if we change Shiki light theme, update also the docsdocs/.vitepress/config.ts
: removepreserveCodeAppearance: true
configurationWe should also review code colors (
vars.css
).