feat: port CodeGroup & CodeBlock to vitepress #232
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d-pollard
changed the title
d-pollard
force-pushed
the
feature/2021-02-09_port-code-group-code-block_dp
branch
from
63288cb
to
e1fe1de
Compare
|
@posva / @yyx990803 what can I do to help this get merged in? |
|
Thank you so much for your PR! And definitely we want this feature. But since we've started the next-theme development, let's do it overthere. Also, Vue.js website has implemented this too so I'm planning to import this from there 👍 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR brings parity to VitePress in terms of
CodeGroupandCodeBlockSome questions I have:
Where should
CodeGroupandCodeBlockbe registered? Currently, I have them insrc/client/app/index.tsbut it feels misplaced; please adviseAlso, this still needs a bit of styling so if someone wants to help or point me in the right direction, that would be super helpful
Thanks,
Derek