Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Enter Key Behavior Conflict with IME in Search UI Select Box #3454

Merged
merged 1 commit into from
Jan 15, 2024

Conversation

bonyuta0204
Copy link
Contributor

@bonyuta0204 bonyuta0204 commented Jan 15, 2024

Description:

Closes: #3450
This pull request addresses an issue with the Enter key behavior in the select box component of the search UI when using an Input Method Editor (IME). The problem was that pressing the Enter key while using an IME not only finalized the IME input but also inadvertently selected a search result in the select box. This behavior disrupted the user experience, especially for IME users.

Changes:

  • Modified the key event handling in the select box component to distinguish between IME input finalization and regular Enter key presses.

Videos:

test_is_composing.mp4

@bonyuta0204 bonyuta0204 changed the title fix: Enter Key Behavior Conflict with IME in Search UI Select Box #3450 fix: Enter Key Behavior Conflict with IME in Search UI Select Box Jan 15, 2024
@bonyuta0204 bonyuta0204 marked this pull request as ready for review January 15, 2024 17:47
@brc-dd brc-dd merged commit cd8ee6f into vuejs:main Jan 15, 2024
7 checks passed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 23, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enter Key Behavior Conflict with IME in Search UI Select Box
2 participants