Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add print style #755

Closed
wants to merge 2 commits into from
Closed

feat: add print style #755

wants to merge 2 commits into from

Conversation

kecrily
Copy link
Contributor

@kecrily kecrily commented Jun 8, 2022

close #593 #612

@kiaking
Copy link
Member

kiaking commented Jun 14, 2022

@kecrily Thanks a lot! Do you know why it doesn't show code block background color? I get this PDF wen printed.

Markdown Extensions _ VitePress.pdf

If this is somekind of printing limitation for saving inks I'm fine but wanted to check in.

@kecrily
Copy link
Contributor Author

kecrily commented Jun 14, 2022

It did not meet expectations and I didn't make changes to this. Is it working properly in print preview? What browser are you using again?

I use Chrome, and this is the pdf I get.

Markdown.pdf


Also in this file I found some components whose styles I did not take into account, such as the collapsed box and the code block that overflows the page. I need to tweak them a bit and check that the background color of this code block is not showing.

@kiaking
Copy link
Member

kiaking commented Jun 14, 2022

I'm using Chrome too. Strange 🤔 Well it's still readable so not a big deal though.

Also in this file I found some components whose styles I did not take into account, such as the collapsed box and the code block that overflows the page. I need to tweak them a bit and check that the background color of this code block is not showing.

OK gotcha. I'll check once again once this changes arive 👍

@brc-dd brc-dd mentioned this pull request Jul 12, 2022
@brc-dd
Copy link
Member

brc-dd commented Dec 30, 2022

Do you know why it doesn't show code block background color?

You probably have "background graphics" disabled in print settings:

image

@brc-dd brc-dd marked this pull request as draft December 30, 2022 14:38
@kiaking
Copy link
Member

kiaking commented Jan 20, 2023

Closing due to it's becoming obsolete.

@kiaking kiaking closed this Jan 20, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 28, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

export to pdf
3 participants