fix: duplicate call to catchError, closes #1133

vuejs · Nov 28, 2021 · eaf1da7 · eaf1da7
1 parent 60347d3
commit eaf1da7
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 3 deletions.
diff --git a/packages/test-e2e/src/components/PartialError.vue b/packages/test-e2e/src/components/PartialError.vue
@@ -15,7 +15,7 @@ function query (errorPolicy) {
       console.log(errorPolicy, result)
     },
     error (error) {
-      console.log(error)
+      console.log('Error', errorPolicy, error)
       this.errors[errorPolicy] = error
     },
   }

diff --git a/packages/test-e2e/tests/e2e/specs/errorPolicy.js b/packages/test-e2e/tests/e2e/specs/errorPolicy.js
@@ -8,7 +8,7 @@ describe('errorPolicy', () => {
 
     // None
     cy.get('.none .result').should('not.contain', 'good').should('not.contain', 'bad')
-    cy.get('.none .error').should('contain', 'Error: GraphQL error: An error')
+    cy.get('.none .error').should('contain', 'Error: An error')
 
     // Ignore
     cy.get('.ignore .result').should('contain', '"good":"good"').should('contain', '"bad":null}')

diff --git a/packages/vue-apollo-option/src/smart-query.js b/packages/vue-apollo-option/src/smart-query.js
@@ -175,7 +175,7 @@ export default class SmartQuery extends SmartApollo {
     // If `errorPolicy` is set to `all`, an error won't be thrown
     // Instead result will have an `errors` array of GraphQL Errors
     // so we need to reconstruct an error object similar to the normal one
-    if (anyErrors) {
+    if (!error && anyErrors) {
       const e = new Error(`GraphQL error: ${errors.map(e => e.message).join(' | ')}`)
       Object.assign(e, {
         graphQLErrors: errors,