fix: fix eslint errors for typescript + e2e-nightwatch setup

vuejs · Feb 5, 2020 · 1b64ff8 · 1b64ff8
1 parent e4410b8
commit 1b64ff8
Show file tree

Hide file tree

Showing 2 changed files with 18 additions and 1 deletion.
diff --git a/packages/@vue/cli-plugin-e2e-nightwatch/generator/template/tests/e2e/_eslintrc.js b/packages/@vue/cli-plugin-e2e-nightwatch/generator/template/tests/e2e/_eslintrc.js
@@ -1,6 +1,9 @@
 <%_ if (hasESLint) { _%>
 module.exports = {
   rules: {
+    <%_ if (hasESLint) { _%>
+    '@typescript-eslint/no-var-requires': 'off',
+    <%_ } _%>
     'no-unused-expressions': 'off'
   }
 }

diff --git a/packages/@vue/cli-plugin-eslint/__tests__/eslintGenerator.spec.js b/packages/@vue/cli-plugin-eslint/__tests__/eslintGenerator.spec.js
@@ -206,11 +206,25 @@ test('airbnb config + typescript + unit-mocha', async () => {
   })
 }, 30000)
 
+test('typescript + e2e-nightwatch', async () => {
+  const { run } = await create('eslint-typescript-nightwatch', {
+    plugins: {
+      '@vue/cli-plugin-eslint': {},
+      '@vue/cli-plugin-typescript': {
+        classComponent: true
+      },
+      '@vue/cli-plugin-e2e-nightwatch': {}
+    }
+  })
+  await run('vue-cli-service lint')
+}, 30000)
+
 test('should be able to parse dynamic import syntax', async () => {
-  await create('eslint-dynamic-import', {
+  const { run } = await create('eslint-dynamic-import', {
     plugins: {
       '@vue/cli-plugin-eslint': {},
       '@vue/cli-plugin-router': {}
     }
   })
+  await run('vue-cli-service lint')
 }, 30000)