Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[@vue/pwa] add option to configure crossorigin tag in manifest link in generated index.html #3933

Closed
BigsonLvrocha opened this issue May 3, 2019 · 1 comment · Fixed by #3939

Comments

@BigsonLvrocha
Copy link
Contributor

What problem does this feature solve?

I work with an apache server with sspi auth, so I've been having problems with the manifest.json include returning 401, with the text:

This server could not verify that you are authorized to access the URL "[...]/manifest.json". You either supplied the wrong credentials (e.g. bad password), or you browser doesn't understand how to supply the credentials required.

Adding crossorigin=use-credentials to the manifest link tag fixes it, but there is no automatic generation, it's something I have to do every time I build a new version. This is something that could be a plugin setting

What does the proposed API look like?

add pwa.crossorigin seeting option to vue.config.js file to specify if crossorigin tag should be added and if so, it's value

@BigsonLvrocha BigsonLvrocha changed the title [@vue/pwa] add option to cofigure crossorigin tag in manifest link in generated index.html [@vue/pwa] add option to configure crossorigin tag in manifest link in generated index.html May 3, 2019
BigsonLvrocha added a commit to BigsonLvrocha/vue-cli that referenced this issue May 4, 2019
sodatea pushed a commit that referenced this issue May 25, 2019
@drewjosh
Copy link

@BigsonLvrocha From the MR and the docs I suppose this should work, but in my app it doesn't. Setting the property crossorigin: "use-credentials" in pwa or manifestOptions property doesn't have any effect on the generated manifest tag.
I'm using @vue/cli-service version 5.0.8. Can you help please?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants