Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

node 18 support #7116

Closed
jacekkarczmarczyk opened this issue Apr 25, 2022 · 14 comments
Closed

node 18 support #7116

jacekkarczmarczyk opened this issue Apr 25, 2022 · 14 comments

Comments

@jacekkarczmarczyk
Copy link

What problem does this feature solve?

It solve the issue that vue cli can't be installed on node 18 because @achrinza/node-ipc@9 doesn't support it

$ yarn
yarn install v1.22.10
[1/4] Resolving packages...
[2/4] Fetching packages...
error @achrinza/node-ipc@9.2.2: The engine "node" is incompatible with this module. Expected version "8 || 10 || 12 || 14 || 16 || 17". Got "18.0.0"
error Found incompatible module.
info Visit https://yarnpkg.com/en/docs/cli/install for documentation about this command.

What does the proposed API look like?

Allow @achrinza/node-ipc@10

@janlauber
Copy link

got the same issue when trying to install:

yarn global add @vue/cli@next

@9mm
Copy link

9mm commented Apr 28, 2022

Im getting an issue with node-ipc and so I tried to upgrade vue/cli with yarn global upgrade-interactive and i get

@achrinza/node-ipc@9.2.2: The engine "node" is incompatible with this module. Expected version "8 || 10 || 12 || 14 || 16 || 17". Got "18.0.0"

@FlorianLoch
Copy link

FlorianLoch commented Apr 29, 2022

I think requiring 9.2.4 (released two days ago, so after this issue has been created) instead of 9.2.3 will do the trick - no need to bump the major version.

https://github.com/achrinza/node-ipc/releases/tag/v9.2.4

@wxh06
Copy link

wxh06 commented Apr 30, 2022

The temporary solution is:

yarn --ignore-engines

Reference:

$ yarn help | grep -- --ignore
    --ignore-engines                    ignore engines check
    --ignore-optional                   ignore optional dependencies
    --ignore-platform                   ignore platform checks
    --ignore-scripts                    don't run lifecycle scripts

@9mm
Copy link

9mm commented May 1, 2022

How do I even create a project with vue-cli? It seems to run yarn automatically

@wxh06
Copy link

wxh06 commented May 2, 2022

How do I even create a project with vue-cli? It seems to run yarn automatically

yarn config set ignore-engines true

@9mm
Copy link

9mm commented May 3, 2022

Ok thanks! Do you know if there a permanent solution in the works? Considering this breaks new installs it seems weird it isnt a higher priority. Also I don't like setting to ignore other things as there may be other conflicts etc.

@FlorianLoch
Copy link

FlorianLoch commented May 3, 2022

I admit, I am wondering too that this topic does not get much more attention. But perhaps Node.js 18 does not have too much adoption yet? But I hardly believe that...

@JsonKody
Copy link

JsonKody commented May 9, 2022

Please update the dependency to @achrinza/node-ipc@9.2.4
I need vue@cli in my work and I must use only Npm (not Yarn) AND I can't downgrade to node 16 easily :/

@LinusBorg
Copy link
Member

LinusBorg commented May 9, 2022

The current version range is already @9 so a fresh install will give you 9.2.4. You need to remove the lockfile though.

I'm wrong.

The reason the version is pinned should be obvious after the fiasco that made a switch to a fork necessary.

We'll see to it that this is upgraded.

Npm also supports overrides for some time now:

https://docs.npmjs.com/cli/v8/configuring-npm/package-json#overrides

@sodatea
Copy link
Member

sodatea commented Jun 21, 2022

Fixed in 5.0.6

@sodatea sodatea closed this as completed Jun 21, 2022
@kabkee
Copy link

kabkee commented Jul 24, 2022

got the same issue when trying to install:

yarn global add @vue/cli@next

saved my life.

jhogstrom added a commit to jhogstrom/appsetup that referenced this issue Feb 2, 2023
* Setting 'ignore-engines=true' prior to invoking
  vue create. This fixed a problem with some package not ready
  to deal with the latest version of node.
  (vuejs/vue-cli#7116)
ideatrails added a commit to ideatrails/taskbox that referenced this issue Mar 1, 2023
@DevCleverton
Copy link

test('top level test', async (t) => {
await t.test('subtest 1', (t) => {
assert.strictEqual(1, 1);
});

await t.test('subtest 2', (t) => {
assert.strictEqual(2, 2);
});
});

@MikeMitterer
Copy link

Now it's the same with node 20 - please support this version

tom-blake added a commit to centrapay/centrapay-docs that referenced this issue Sep 7, 2023
This started with an attempt to upgrade Astro to v3.0
- Astro v3.0 no longer supports Node 16. We need to upgrade our tooling
  to Node 18. See https://docs.astro.build/en/guides/upgrade-to/v3/#removed-support-for-node-16
- vue-cli contains a dependency that is not compatible with Node 18
  (@achrinza/node-ipc@9). See vuejs/vue-cli#7116

This compatible issue has been fixed but Centrapay Docs does not need
vue-cli and the module itself is in maintenance mode. See https://cli.vuejs.org/

Removing these vue-cli dependencies required a change to use eslint
directly for linting instead. We are now using eslint-plugin-vue (it was
already installed) as per Vue's official guidelines. See https://vuejs.org/guide/scaling-up/tooling.html#linting

Test plan:
- Confirm Eslint is linting Vue files using its --debug flag
- Confirm that the local dev server runs correctly
- Confirm that the static Centrapay Docs site builds correctly
- Confirm the site navigation still works
tom-blake added a commit to centrapay/centrapay-docs that referenced this issue Sep 7, 2023
This started with an attempt to upgrade Astro to v3.0
- Astro v3.0 no longer supports Node 16. We need to upgrade our tooling
  to Node 18. See https://docs.astro.build/en/guides/upgrade-to/v3/#removed-support-for-node-16
- vue-cli contains a dependency that is not compatible with Node 18
  (@achrinza/node-ipc@9). See vuejs/vue-cli#7116

This compatible issue has been fixed but Centrapay Docs does not need
vue-cli and the module itself is in maintenance mode. See https://cli.vuejs.org/

Removing these vue-cli dependencies required a change to use eslint
directly for linting instead. We are now using eslint-plugin-vue (it was
already installed) as per Vue's official guidelines. See https://vuejs.org/guide/scaling-up/tooling.html#linting

I've also added init: true to the docker compose config to forward signals correctly.

Test plan:
- Confirm Eslint is linting Vue files using its --debug flag
- Confirm that the local dev server runs correctly
- Confirm that the static Centrapay Docs site builds correctly
- Confirm the site navigation still works
tom-blake added a commit to centrapay/centrapay-docs that referenced this issue Sep 7, 2023
This started with an attempt to upgrade Astro to v3.0
- Astro v3.0 no longer supports Node 16. We need to upgrade our tooling
  to Node 18. See https://docs.astro.build/en/guides/upgrade-to/v3/#removed-support-for-node-16
- vue-cli contains a dependency that is not compatible with Node 18
  (@achrinza/node-ipc@9). See vuejs/vue-cli#7116

This compatible issue has been fixed but Centrapay Docs does not need
vue-cli and the module itself is in maintenance mode. See https://cli.vuejs.org/

Removing these vue-cli dependencies required a change to use eslint
directly for linting instead. We are now using eslint-plugin-vue (it was
already installed) as per Vue's official guidelines. See https://vuejs.org/guide/scaling-up/tooling.html#linting

I've also added init: true to the docker compose config to forward signals correctly.

See our dev environment for a live preview - http://centrapay-docs.dev.s3-website-ap-southeast-1.amazonaws.com

Test plan:
- Confirm Eslint is linting Vue files using its --debug flag
- Confirm that the local dev server runs correctly
- Confirm that the static Centrapay Docs site builds correctly
- Confirm the site navigation still works
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests