Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: implement version-related APIs for `GeneratorAPI` #4000

Open
wants to merge 3 commits into
base: dev
from

Conversation

Projects
None yet
2 participants
@sodatea
Copy link
Member

commented May 15, 2019

To discuss: is the name serviceVersion / assertServiceVersion ideal? Any other naming ideas?

sodatea added some commits May 15, 2019

feat: add `version` / `assertVersion` for GeneratorAPI
Note this is for checking the global `@vue/cli` version.
@novbing

This comment has been minimized.

Copy link

commented May 15, 2019

To discuss: is the name serviceVersion / assertServiceVersion ideal? Any other naming ideas?

serviceVersion / exactServiceVersion
serviceVersion / lockedServiceVersion
serviceVersion / workServiceVersion
...

@sodatea

This comment has been minimized.

Copy link
Member Author

commented May 15, 2019

Well, I think the assert part is accurate. But is serviceVersion clear enough to indicate that it is actually a per-project version number, in contrast to the version field as a global version number?

@novbing

This comment has been minimized.

Copy link

commented May 16, 2019

currentVersion
localVersion
?

@sodatea

This comment has been minimized.

Copy link
Member Author

commented May 20, 2019

currentVersion does not distinguish it from the global version field.

localVersion may be a good alternative but I'm not sure…
While @vue/cli-service is local, it is not depended on by GeneratorAPI

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.