Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore!: ensure consistent directory structure for all modes #4323

Merged
merged 1 commit into from Jul 21, 2019

Conversation

@sodatea
Copy link
Member

@sodatea sodatea commented Jul 20, 2019

BREAKING CHANGE:
Changing directory structure, though now becoming more intuitive, may
still break users' workflows, so it's considered a breaking change.

Fixes #4215.
Fixes #3767.
Fixes #3613.

BREAKING CHANGE:
Changing directory strcuture, though now becoming more intuitive, may
still break users' workflows, so it's considered a breaking change.
Akryum
Akryum approved these changes Jul 20, 2019
@sodatea sodatea merged commit e2e3469 into vuejs:dev Jul 21, 2019
7 checks passed
@sodatea sodatea deleted the directory-structure branch Jul 21, 2019
@ma7moudat
Copy link

@ma7moudat ma7moudat commented Aug 22, 2019

any idea when this will be in master? I really need it 🙏😗

@sodatea
Copy link
Member Author

@sodatea sodatea commented Aug 22, 2019

It's shipped in 4.0 rc already. Just install @vue/cli-service@next.

@rayfoss
Copy link
Contributor

@rayfoss rayfoss commented Apr 27, 2021

I'm on 4.5, yet the PWA plugin generates vastly different precache manifests when built by a --watch call. The first build works fine, the issue comes only after making a change that is picked up by watch.

Workaround on Debian, Windows WSL2, RHEL, ChromeOS/Crostini, Android/Termux, Arch/Manjaro etc...:
Uses sudo apt install inotify-tools

npx vue-cli-service build --mode production
inotifywait -rme close_write ./src/ |
while read dir action file; do
  echo "The file '$file' appeared in directory '$dir' via '$action'"
  npx vue-cli-service build --mode production
done

There are so many workarounds needed to get a decent service worker play nice with vue cli... by default you don't get ESM, env variables, HMR or a reasonable dev workflow... I know webpack 5 fixes all that

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment