Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add sourceType: 'unambiguous' to babel preset #4797

Merged
merged 1 commit into from
Nov 7, 2019

Conversation

sodatea
Copy link
Member

@sodatea sodatea commented Nov 5, 2019

Fixes #4773
The reasoning is stated at #4773 (comment)

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Docs
  • Underlying tools
  • Other, please describe:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

Other information:

@viniciuskneves
Copy link

I was migrating to Vue CLI 4 manually and I think this option is not documented here: https://github.com/vuejs/vue-cli/tree/v4.2.3/packages/@vue/babel-preset-app

Am I looking at the right place or is it documented somewhere else?

@sodatea
Copy link
Member Author

sodatea commented Mar 20, 2020

It's a babel option: https://babeljs.io/docs/en/options#sourcetype

This PR only changes its default value to better handle edge cases. It doesn't affect actual usage.

@viniciuskneves
Copy link

It's a babel option: https://babeljs.io/docs/en/options#sourcetype

This PR only changes its default value to better handle edge cases. It doesn't affect actual usage.

Yep, but from @LinusBorg #4773 (comment) I thought it would be added to the docs (as a reference).

Just to be clear that it is not blocking me or anything. It is just because I was reading this PR + Issue mentioned and then doubled checked the docs.

I was using unambiguous in my project and could remove it after upgrading my dependencies as suggested.

@sodatea
Copy link
Member Author

sodatea commented Mar 20, 2020

Yeah, you are right, we do need to add it in the docs.

@sodatea
Copy link
Member Author

sodatea commented Mar 20, 2020

PR's welcome :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

@vue/cli 4.0.5 transpileDependencies invalid
2 participants