Remove linter option TSLint

[Shinigami92]

What kind of change does this PR introduce? (check at least one)

• Bugfix
• Feature
• Code style update
• Refactor
• Docs
• Underlying tools
• Other, please describe:

Does this PR introduce a breaking change? (check one)

• Yes
• No

Other information:

References #5064

[Shinigami92]

Don't know what to do with the docs:

https://github.com/Shinigami92/vue-cli/blob/4ced5506ceaaf9f682a45d41fa9b1d73364af293/packages/%40vue/cli-plugin-typescript/README.md#injected-commands

https://github.com/Shinigami92/vue-cli/blob/4ced5506ceaaf9f682a45d41fa9b1d73364af293/docs/core-plugins/typescript.md#injected-commands

https://github.com/Shinigami92/vue-cli/blob/4ced5506ceaaf9f682a45d41fa9b1d73364af293/docs/ru/core-plugins/typescript.md#%D0%B2%D0%BD%D0%B5%D0%B4%D1%80%D1%8F%D0%B5%D0%BC%D1%8B%D0%B5-%D0%BA%D0%BE%D0%BC%D0%B0%D0%BD%D0%B4%D1%8B

[Shinigami92]

I don't know if removing the two tests is the right way, but in the past it seemed that they only passed if tsLint was set to true anyway?!

[sodatea]

Thanks for the PR!
But FYI, it is a breaking change

[Shinigami92]

Thanks for the PR!
But FYI, it is a breaking change

Thanks for your review
You are absolutely right, of course, and that was actually not intended at all.
This PR is only intended to remove the selection option and the associated code.
No code should be removed that has nothing to do with the generation and I probably removed a little too much here last night. I will revert this parts.

This PR should aim a cli version 4.2.0.
The complete removal of non-generating code should be done in another PR and could be in a cli version 5.0.

[Shinigami92]

Ok ... since some tests use the generator to test linting with TSLint, I will completely revert the second commit

[Shinigami92]

And because I just revert the changes and didn't use reset, we don't have to find the parts again for the upcoming breaking change PR :)

[sodatea]

I just started working on the next major version.
I think we can revert the previous reversion, to introduce breaking changes :)

[Shinigami92]

@sodatea Thanks for notifying me, I have updated this PR
Please have a look / review

[Shinigami92]

The one test lint with no lintOnSave wants to have lintOnSave to be false
Maybe we should assign false as default value were it's defined? 🤔 (same for scripts.lint)

Or remove the expectations?

[sodatea]

Yeah, I think we can just remove the two test cases

[sodatea]

Thanks!

[Shinigami92]

Thanks!

I'm happy to be part of the Vue ecosystem and community

I am happy to return your thanks to the community ❤️