Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cli-service): remove highlight config output #6084

Closed
wants to merge 1 commit into from
Closed

fix(cli-service): remove highlight config output #6084

wants to merge 1 commit into from

Conversation

fz6m
Copy link

@fz6m fz6m commented Nov 24, 2020

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Docs
  • Underlying tools
  • Other, please describe:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

Other information:

    vue inspect > output.js
{
  [36mmode�[39m: [31m'production'[39m,
  [36mcontext�[39m: [31m'D:\\Project\\vue\\vue-config-demo'[39m,
  [36mdevtool�[39m: [31m'source-map'[39m,
  [36mnode�[39m: {
    [36msetImmediate�[39m: [34mfalse�[39m,

   // ......

The output of utf-16 by default will produce unintelligible code.

@IndexXuan
Copy link
Contributor

IndexXuan commented Nov 30, 2020

+1, vue inspect > webpack.dev.js is not readable ...
@sodatea

@IndexXuan
Copy link
Contributor

  "resolutions": {
    "cli-highlight": "2.1.4"
  },

works
@fz6m @sodatea

@IndexXuan
Copy link
Contributor

felixfbecker/cli-highlight@7384705
it breaks vue inspect

@felixfbecker
Copy link

felixfbecker commented Dec 1, 2020

Sorry for the inconvenience, auto-detected color support should be respected in v2.1.9 felixfbecker/cli-highlight@988d209

@fangbinwei
Copy link
Collaborator

Thanks! Close it, since it has been solved in cli-highlight v2.1.9 with the help of @felixfbecker .

@fangbinwei fangbinwei closed this Dec 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants