Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed the parsing of custom block to parse like Vue3 parser. #90

Merged
merged 4 commits into from
Dec 7, 2020

Conversation

ota-meshi
Copy link
Member

This PR changes the custom blocks to parse as RAWTEXT.

It parses like the Vue 3 SFC parser.
However, if the file name is other than .vue such as .html, the custom block will not be parsed as RAWTEXT.

In the following edge case, there is a difference between the parsed result and the one before the change.

<custom-block>
  End Tag in the Attr. e.g. <foo attr="</custom-block>" ></foo>
</custom-block>

The content of custom block is
End Tag in the Attr. e.g. <foo attr="</custom-block>" ></foo>
in Vue2, but
End Tag in the Attr. e.g. <foo attr="
in Vue3.
With this PR change, the parser will get the same parsing results as Vue3.

close #79

@ota-meshi ota-meshi changed the title Support for custom blocks Changed custom block to parse like Vue3 parser. Dec 4, 2020
@ota-meshi ota-meshi changed the title Changed custom block to parse like Vue3 parser. Changed the parsing of custom block to parse like Vue3 parser. Dec 4, 2020
@ota-meshi ota-meshi merged commit 495abaa into master Dec 7, 2020
@ota-meshi ota-meshi deleted the supports-custom-block branch December 7, 2020 08:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for custom blocks
1 participant