Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow babelInlineConfig to be passed in #100

Closed
wants to merge 5 commits into from

Conversation

Globegitter
Copy link

@Globegitter Globegitter commented Aug 17, 2018

We are creating our babelConfig programatically and with babel-jest it is already possible to pass that in, but not here. With these changes I can now write my custom vue-jest transform in the following way:

...
module.exports = {
    process(src, filename, jestConfig) {
        return vueJest.process(src, filename, jestConfig, {}, babelOptions);
    },
};

@Globegitter
Copy link
Author

Tests are passing now.

@eddyerburgh
Copy link
Member

I think this should be added to the Jest config option object, rather than added as an extra object. Could you also please add some tests?

@justinhelmer
Copy link
Contributor

@eddyerburgh - done. Check #110 / #111 .

@justinhelmer
Copy link
Contributor

I believe this PR can be closed now that #111 has been merged.

@eddyerburgh eddyerburgh closed this Oct 7, 2018
@Globegitter
Copy link
Author

@justinhelmer thanks for that I will check it out but it does sound good.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants