Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set __file to file basename in production #1368

Merged

Conversation

chrisvfritz
Copy link

@chrisvfritz chrisvfritz commented Jul 31, 2018

Combined with this change in vue-component-compiler, this will allow names to be inferred for all .vue files, even those precompiled for production. That means 3rd-party component libraries will never have to define names if they're using .vue files! 馃檪

We've also made this change in the devtools, so that we don't allow users to open a file if we only have the basename instead of the full path.

@chrisvfritz chrisvfritz changed the title Set file basename to __file in production Set __file to file basename in production Jul 31, 2018
@chrisvfritz
Copy link
Author

chrisvfritz commented Jul 31, 2018

@yyx990803 I believe this should be the final change necessary to make the name property truly only necessary for recursive components. 馃檪

@privatenumber
Copy link

Seems like the docs here should be updated to reflect this:

Also, when inspecting an app in the vue-devtools, unnamed components will show up as , which isn鈥檛 very informative.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants