fix: keep build stable when run in a different path #2040
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexander-akait
approved these changes
May 7, 2023
|
@yyx990803 this is the correct fix for stable file content |
Merged
mvorisek
changed the title
|
Hi @sodatea, would it be possible to merge this PR, please? |
|
Sure. I'm away from home today, though. I'll take a look and try to cut a new release this weekend. |
haoqunjiang
approved these changes
May 28, 2023
haoqunjiang
changed the title
|
@sodatea the webpack 4 tests timeout for some unknown/unrelated reason, but otherwise the tests pass - can a new release be tagged? |
freddy38510
pushed a commit
to freddy38510/vue-loader
that referenced
this pull request
May 28, 2023
By making the `exportHelperPath` a relative path so that the generated code is consistent.
|
Fixed and released. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #2028, full credit goes to @alexander-akait, thank you!
I have tested this fix and I can confirm the original issue is fixed with it.