Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix #943, should consider path or file name includes dot #945

Merged
merged 5 commits into from Sep 1, 2017
Merged

fix #943, should consider path or file name includes dot #945

merged 5 commits into from Sep 1, 2017

Conversation

Elevista
Copy link

@Elevista Elevista commented Aug 18, 2017 •
edited 

let filename = '../vue.comp.intermediate'
filename.substring(0, filename.lastIndexOf(path.extname(filename))) + '.vue'
// => "../vue.comp.vue"

@Elevista Elevista mentioned this pull request Aug 18, 2017
Closed
@Elevista Elevista changed the title fix #943, regex should consider path or file name includes dot fix #943, should consider path or file name includes dot Aug 18, 2017
@Elevista
Copy link
Author

Elevista commented Aug 18, 2017 •
edited

+ fix #895 (comment)

@kazupon
provide sourceRoot option was correct way to keep file path in source map.
sorry for this PR
#895

@kazupon
Copy link
Member

kazupon commented Aug 18, 2017

@Elevista
LGTM

/ping @yyx990803
Please check it!

@yyx990803 yyx990803 merged commit c48e6fe into vuejs:master Sep 1, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Elevista @kazupon @yyx990803