Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Detecting comments as Vue Router routes. #13

Closed
znck opened this issue Oct 1, 2016 · 5 comments
Closed

Detecting comments as Vue Router routes. #13

znck opened this issue Oct 1, 2016 · 5 comments
Labels
bug

Comments

@znck
Copy link
Member

znck commented Oct 1, 2016

Comment /* ... */ is treated as /*foo route!

screen shot 2016-10-01 at 13 26 07
@chrisvfritz
Copy link
Contributor

Interesting - I didn't anticipate the use case of comments wrapped in quotes. This is fixed now.

@chrisvfritz chrisvfritz added the bug label Oct 1, 2016
@znck
Copy link
Member Author

znck commented Oct 1, 2016

@chrisvfritz Comments are not in quotes!

@chrisvfritz
Copy link
Contributor

In the example you posted ('/* Load comments */'), there appears to be single quotes on either side of the comment. If that's not the case in your code, could you post the exact line (including spaces) that causes the problem, if it's still present?

@znck
Copy link
Member Author

znck commented Oct 1, 2016

Sorry! debug('/* Load components */'); Not a bug!

@chrisvfritz
Copy link
Contributor

Ah, OK - so there are single quotes on either side. Glad it's working now. 😃

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@chrisvfritz @znck