Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Imports in normal <script> are exposed to template when using alongside <script setup> #3238

Closed
egoist opened this issue Feb 15, 2021 · 3 comments
Closed

Imports in normal <script> are exposed to template when using alongside <script setup> #3238

egoist opened this issue Feb 15, 2021 · 3 comments
Labels
🔨 p3-minor-bug Priority 3: this fixes a bug, but is an edge case that only affects very specific usage.

Comments

@egoist
Copy link

egoist commented Feb 15, 2021

Version

3.0.5

Reproduction link

https://repl.it/@egoist/SpecificEnergeticPackages#src/App.vue

Steps to reproduce

See the link

What is expected?

Do not expose imports in normal <script>

What is actually happening?

imports in normal <script> are also exposed. which is unexpected.

bug
@HcySunYang
Copy link
Member

I'm not sure if this is intentional, but it seems reasonable that imports in normal scripts are not exposed to templates

@egoist
Copy link
Author

egoist commented Feb 16, 2021

👌 Just took a look at the code, it seems to be an intentional design

@egoist egoist closed this as completed Feb 16, 2021
@HcySunYang HcySunYang reopened this Feb 17, 2021
@HcySunYang HcySunYang added the ✨ feature request New feature or request label Feb 17, 2021
@HcySunYang HcySunYang mentioned this issue Feb 18, 2021
Closed
@egoist egoist mentioned this issue Feb 25, 2021
Open
@HcySunYang HcySunYang mentioned this issue Apr 10, 2021
Closed
@HcySunYang HcySunYang mentioned this issue Nov 19, 2021
Closed
@HcySunYang HcySunYang added 🔨 p3-minor-bug Priority 3: this fixes a bug, but is an edge case that only affects very specific usage. and removed ✨ feature request New feature or request labels Nov 19, 2021
@HcySunYang
Copy link
Member

Raise a new PR to fix this.

@egoist egoist closed this as completed Dec 20, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Oct 6, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
🔨 p3-minor-bug Priority 3: this fixes a bug, but is an edge case that only affects very specific usage.
Projects
None yet
Milestone
No milestone
2 participants
@egoist @HcySunYang