Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: include compiler-sfc in aliases and tsconfig paths #435

Merged
merged 1 commit into from
Nov 9, 2019
Merged

build: include compiler-sfc in aliases and tsconfig paths #435

merged 1 commit into from
Nov 9, 2019

Conversation

underfin
Copy link
Member

@underfin underfin commented Nov 7, 2019

No description provided.

@underfin
Copy link
Member Author

underfin commented Nov 7, 2019 •
edited
Loading

I want to add some test for compiler-sfc package.But meet some problem.

Pattern: ./packages/compiler-sfc/_tests_/parse.spec.ts - 0 matches

It is caused by not scan the test files.
So, I want to get some help.

@yyx990803 yyx990803 merged commit 9e48c51 into vuejs:master Nov 9, 2019
@yyx990803
Copy link
Member

yyx990803 commented Nov 9, 2019 •
edited
Loading

The test directory name should be __tests__ with two underscores. Some tests can be ported from here: https://github.com/vuejs/component-compiler-utils/tree/master/test

@vue-bot
Copy link
Contributor

vue-bot commented Nov 9, 2019

Hey @underfin, thank you for your time and effort spent on this PR, contributions like yours help make Vue better for everyone. Cheers! 💚

@underfin underfin deleted the build branch November 12, 2019 13:56
@underfin
Copy link
Member Author

Thanks a lot!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@underfin @yyx990803 @vue-bot