Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add vue-router docs favicon? #3001

Open
BARNZ opened this issue Oct 18, 2019 · 4 comments

Comments

@BARNZ
Copy link

@BARNZ BARNZ commented Oct 18, 2019

What problem does this feature solve?

I notice the vue-router docs does not have any favicon. Can one be added?

What does the proposed API look like?

favicon.ico

Just helps to identify it when users have the tab pinned like me:

image

@posva

This comment has been minimized.

Copy link
Member

@posva posva commented Oct 18, 2019

It would be the Vue icon though

@BARNZ

This comment has been minimized.

Copy link
Author

@BARNZ BARNZ commented Oct 18, 2019

Yeah saw that with the vue docs and vuex docs

image

Could do a slight little variant to distinguish them :)

@posva

This comment has been minimized.

Copy link
Member

@posva posva commented Oct 18, 2019

for anybody doing the PR, no variation is needed (vuejs/vue#6305)

BARNZ added a commit to BARNZ/vue-router that referenced this issue Oct 18, 2019
@BARNZ

This comment has been minimized.

Copy link
Author

@BARNZ BARNZ commented Oct 18, 2019

Added via #3002

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.