1102: $route returns consistent value across all Vue instances #1108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
jhartman86
commented
Jan 20, 2017
jhartman86
commented
- Allow injecting router to discrete Vue instances and ensure the $route (getter) returns consisten value
- Allow injecting router to discrete Vue instances and ensure the $route (getter) returns consisten value
|
Maintainers - not expecting for this PR to get accepted right away as I'm guessing it violates the coding standards somewhere. If feedback can be provided on what needs to be fixed for it to be accepted it'd be great. Note - the simplest fix was to keep track of all the app instances and just set the private _route property on all of them. That effectively accomplishes keeping the $route value in sync across all instances. |
posva
reviewed
Jan 20, 2017
| @@ -89,7 +92,11 @@ export default class VueRouter { | |||
| } | |||
|
|
|||
| history.listen(route => { | |||
| this.app._route = route | |||
| this.apps.forEach((app) => { | |||
| if (app) { | |||
There was a problem hiding this comment.
A check shouldn't be necessary, should it?
There was a problem hiding this comment.
Thats what I thought as well, but the syntax check wouldn't let it pass. Don't remember exactly, but it was along the lines of "Cannot set property on a possibly null value".
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.