fix: not respect base tag #1448
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sabakugaara
force-pushed
the
feature/respect-base-tag
branch
from
7a76f2f
to
aa29a4e
Compare
|
Incompatible with #1396 |
|
I will update this later |
- respect `<base>` tag in case: when view page cache, search engine will inject `<base>` tag to current html but `window.location` is still `webcache.googleusercontent.com/search?q=cache:...` in most situation `baseURI` is equal to `window.location`
sabakugaara
force-pushed
the
feature/respect-base-tag
branch
from
aa29a4e
to
1b82c5d
Compare
In hash mode, maybe should ignore baseURI
|
这个修改会和 #1396 不兼容，可能需要再考虑下 |
yyx990803
added a commit
that referenced
this pull request
Jun 17, 2017
This reverts commit 39393e4.
Nicholas-Liu
pushed a commit
to Nicholas-Liu/upyun.com
that referenced
this pull request
Aug 23, 2017
|
Hello. When will this fix be released? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
priority use document.baseURI to replace window.location, fix #1426
in case: when view page cache, search engine will inject
<base>tag to current htmlbut
window.locationis stillwebcache.googleusercontent.com/search?q=cache:...in most situation
baseURIis equal towindow.location