Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't use createObservableMethod with RxJS 6 #82

Closed
zero298 opened this issue May 2, 2018 · 1 comment
Closed

Can't use createObservableMethod with RxJS 6 #82

zero298 opened this issue May 2, 2018 · 1 comment

Comments

@zero298
Copy link

zero298 commented May 2, 2018

It looks like createObservableMethod will fail because of how it checks to see if share() is supported here.

if (!Rx.Observable.prototype.share) {...}

Right now, it is checking for support on the prototype of Observable when share() is actually somewhere around RxJS.operators.share(). Is there a way to address this through the new piping mechanism without having to utilize the rxjs-compat module?

This is sort of related to #69 but since createObservableMethod directly uses share() off the Observable prototype, the feature is broken.

@regou regou closed this as completed Jun 2, 2018
@regou
Copy link
Collaborator

regou commented Jun 2, 2018

#83

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants