Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

I'd like to help you rework this a bit #83

Closed
benlesh opened this issue May 30, 2018 · 0 comments
Closed

I'd like to help you rework this a bit #83

benlesh opened this issue May 30, 2018 · 0 comments

Comments

@benlesh
Copy link
Contributor

benlesh commented May 30, 2018

I think this library has some great goals, and I'd like to see it take full advantage of RxJS v6's modularity and "tree-shakability"

I recommend:

  1. Dropping support for RxJS 4
  2. Dropping the use of the Rx global
  3. Using RxJS 6 directly in this library (This will also enable supporting RxJS 5 if users want that)
  4. Getting users to use "pipeable" operators.

All of this will drastically simplify your codebase as well as make apps built with vue-rx and Webpack 4 a lot smaller.
benlesh added a commit to benlesh/vue-rx that referenced this issue May 30, 2018
@benlesh
feat(RxJS 6): updated RxJS version 6
46defa9 
- Library now uses RxJS directly rather than installing it somehow
- Removes a lot of unnecessary null checks
- Updates to use pipeable operators
- Users using RxJS 5 will need to install rxjs-compat
- Updates tests to use RxJS v6
- Adds notes about possible future changes regarding RxJS
- Fixes a test relying on synchronous error throwing, that behavior was
  removed in RxJS 6 due to bugs it could cause.

BREAKING CHANGE: RxJS 4 no longer supported
BREAKING CHANGE: Rx global no longer required
BREAKING CHANGE: RxJS 5 users will need to install rxjs-compat

Resolves vuejs#83
@benlesh benlesh mentioned this issue May 30, 2018
Merged
yyx990803 pushed a commit that referenced this issue May 30, 2018
@benlesh @yyx990803
feat(RxJS 6): updated RxJS version 6 (#84)
48484a7 
- Library now uses RxJS directly rather than installing it somehow
- Removes a lot of unnecessary null checks
- Updates to use pipeable operators
- Users using RxJS 5 will need to install rxjs-compat
- Updates tests to use RxJS v6
- Adds notes about possible future changes regarding RxJS
- Fixes a test relying on synchronous error throwing, that behavior was
  removed in RxJS 6 due to bugs it could cause.

BREAKING CHANGE: RxJS 4 no longer supported
BREAKING CHANGE: Rx global no longer required
BREAKING CHANGE: RxJS 5 users will need to install rxjs-compat

Resolves #83
This was referenced Jun 2, 2018
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@benlesh