Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Feature v-stream directive #34

Merged
merged 8 commits into from
Mar 21, 2017
Merged

New Feature v-stream directive #34

merged 8 commits into from
Mar 21, 2017

Conversation

regou
Copy link
Collaborator

@regou regou commented Mar 17, 2017

#33
v-stream:plus$.click="delta2"

This feature is intend to replace $fromDOMEvent

@yyx990803 yyx990803 merged commit 3a9bd0a into vuejs:master Mar 21, 2017
@yyx990803
Copy link
Member

Hey @regou - sorry for taking so long to review it. This is really cool! I made some adjustments on the usage syntax to make it more consistent with v-on, it might look a bit different from your original implementation, but thank you so much for laying out the groundwork for this new feature. It is now shipped in 3.0.

@regou
Copy link
Collaborator Author

regou commented Mar 21, 2017

@yyx990803 It's my pleasure, before you release, maybe add some ci tests?
Someone already done part of that: see @bfanger 's fork

https://github.com/bfanger/vue-rx/tree/unittests/test/unit

@yyx990803
Copy link
Member

@regou absolutely, adding tests soon.

@bfanger
Copy link
Contributor

bfanger commented Mar 21, 2017

I recently completed an angular2/ionic project, my next project is a vue project again, i hope to carve out some time to finish the vue-rx improvements i've made.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants