Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Subscription error #55

Merged
merged 1 commit into from
Sep 8, 2017
Merged

Subscription error #55

merged 1 commit into from
Sep 8, 2017

Conversation

regou
Copy link
Collaborator

@regou regou commented Sep 7, 2017

Should not silenced If user didn't handling errors on subscription
In sourcecode, oncomplete handler is unnecessary

#43

@regou regou self-assigned this Sep 7, 2017
@yyx990803 yyx990803 merged commit cde4f9d into vuejs:master Sep 8, 2017
@yyx990803
Copy link
Member

I was about to release a patch version but then I realized this is technically a breaking change - if the user had previously swallowed errors, the upgrade would break their app. Thoughts?

@regou
Copy link
Collaborator Author

regou commented Sep 9, 2017

@yyx990803 When an error occurred and arrived at the final subscribe error callback , the stream will die & stop whatever the callback throw the error or not.
If user want a forever-alived stream, they have to catch it before the final subscribe callback.
An article about this

A subscribe helper sub4ever maybe is the next milestone, but it have to turn an ob into a hot stream, not sure the best way to do that...

@regou
Copy link
Collaborator Author

regou commented Sep 9, 2017

The stream will die anyway. But other part of code may affected
So yes.This should include in next major release

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants