Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Template-tag regex matches components prefixed "template" #183

Closed
abjugard opened this issue Jun 18, 2019 · 3 comments
Closed

Template-tag regex matches components prefixed "template" #183

abjugard opened this issue Jun 18, 2019 · 3 comments

Comments

@abjugard
Copy link

Current implementation of the template-tag regex matches Vue components with a name starting with the word "template". It is a simple fix for the new branch, and I have made a PR correcting it there.
abjugard pushed a commit to abjugard/vue-syntax-highlight that referenced this issue Jun 18, 2019
BUG vuejs#183: Correct template-tag regex
e133b59
@abjugard
Copy link
Author

Here's some screenshots to illustrate my point.

Current behaviour:
image

With my patch applied:
image

@abjugard
Copy link
Author

Yes, I see that my component can be simplified, not the point of this issue 😄

skyronic pushed a commit that referenced this issue Jan 20, 2020
@skyronic
BUG #183: Correct template-tag regex
6eb71bc
@skyronic
Copy link
Collaborator

Thank you for your fix!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@skyronic @abjugard