fix: setProps validates keys against component options (#416)

vuejs · Feb 7, 2018 · a63e34d · a63e34d
1 parent 81c40da
commit a63e34d
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 0 deletions.
diff --git a/src/wrappers/wrapper.js b/src/wrappers/wrapper.js
@@ -460,6 +460,12 @@ export default class Wrapper implements BaseWrapper {
       this.vm.$options.propsData = {}
     }
     Object.keys(data).forEach((key) => {
+      // Ignore properties that were not specified in the component options
+      // $FlowIgnore : Problem with possibly null this.vm
+      if (!this.vm.$options._propKeys.includes(key)) {
+        return
+      }
+
       // $FlowIgnore : Problem with possibly null this.vm
       if (this.vm._props) {
         this.vm._props[key] = data[key]

diff --git a/test/specs/wrapper/setProps.spec.js b/test/specs/wrapper/setProps.spec.js
@@ -33,6 +33,13 @@ describeWithShallowAndMount('setProps', (mountingMethod) => {
     expect(wrapper.find('.prop-2').element.textContent).to.equal(prop2)
   })
 
+  it('does not add properties not defined in component', () => {
+    const undefinedProp = 'some value'
+    const wrapper = mountingMethod(ComponentWithProps)
+    wrapper.setProps({ undefinedProp })
+    expect(wrapper.props().undefinedProp).to.be.undefined
+  })
+
   it('runs watch function when prop is updated', () => {
     const wrapper = mountingMethod(ComponentWithWatch)
     const prop1 = 'testest'