Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should shallow rendering stub child lifecycle hooks by default? #10

Closed
eddyerburgh opened this issue Jun 21, 2017 · 1 comment
Closed

Comments

@eddyerburgh
Copy link
Member

eddyerburgh commented Jun 21, 2017

I've added shallow to vue-test-utils and avoriaz.

It replaces each childs render function with an empty function, and replaces each child component lifecycle hook with an empty function.

I've already had a user ask if there was a way to bypass the lifecycle hooks stubbing.

I think they should be stubbed by default, but should there be an option to pass that will stop shallow replacing child lifecycle hooks?

What do people think?

@eddyerburgh eddyerburgh changed the title Should shallow rendering stub child lifecycle events by default? Should shallow rendering stub child lifecycle hooks by default? Jun 21, 2017
@eddyerburgh
Copy link
Member Author

Closing, because I actually misunderstood the issue I received.

I don't think there is a legitimate case for needing lifecycle hooks on child components when shallow rendering

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant