Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

attachToDocument - outdated deprecation warning #1725

Closed
Mikilll94 opened this issue Oct 25, 2020 · 2 comments · Fixed by #1852
Closed

attachToDocument - outdated deprecation warning #1725

Mikilll94 opened this issue Oct 25, 2020 · 2 comments · Fixed by #1852
Labels
good first issue

Comments

@Mikilll94
Copy link

Documentation Feedback

Screenshot 2020-10-25 at 12 33 14

I think this deprecation warning is outdated. After discussion in #1578, the recommended way to replace attachToDocument: true should be attachTo: document.body.

Affected documentation page:

https://vue-test-utils.vuejs.org/api/options.html#attachtodocument
@Mikilll94 Mikilll94 changed the title Outdated deprecation warning attachToDocument - outdated deprecation warning Oct 25, 2020
@afontcu
Copy link
Member

afontcu commented Oct 26, 2020

Sounds about right! Fancy to open up a PR? 🙌

@raphaeloliveira-hotmart
Copy link

A question regarding the new way: Do we still need to call wrapper.destroy() when using the "special handling" of attachTo: document.body? I guess so but still, just confirming :-)

@RaphaelDDL RaphaelDDL mentioned this issue May 26, 2021
Merged
12 tasks
lmiller1990 pushed a commit that referenced this issue Jun 13, 2021
@RaphaelDDL
fix: Updates attachToDocument documentation tip (#1852)
9c05f2e 
Closes #1725

Updates  attachToDocument documentation tip from the div boilerplate from #1584 & #1611 to the new handling from #1578 & #1699
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix #1725: Updates attachToDocument documentation tip
3 participants
@afontcu @Mikilll94 @raphaeloliveira-hotmart