Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: don't fire event on disabled element #424

Merged
merged 2 commits into from
Feb 11, 2018
Merged

fix: don't fire event on disabled element #424

merged 2 commits into from
Feb 11, 2018

Conversation

eddyerburgh
Copy link
Member

@eddyerburgh eddyerburgh merged commit e85f20a into vuejs:dev Feb 11, 2018
@eddyerburgh eddyerburgh deleted the handle-disabled-elements-in-trigger branch February 11, 2018 10:41
@micgro42
Copy link

Unfortunately, this solution is too far-reaching. This also disables events, for example, on links with the disabled attribute.
While that might be the desired final state, it is something that needs to be asserted by tests. Just plainly disabling the trigger method in that case prevents me from doing so.

@micgro42 micgro42 mentioned this pull request Oct 15, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

'Disabled' attribute on buttons is ignored during testing
2 participants
@eddyerburgh @micgro42