Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stub globally registered components (fix #1272) #1441

Merged
merged 1 commit into from Feb 25, 2020

Conversation

thejcannon
Copy link
Contributor

When specifying the components to stub, merge the globally registered components into the locally registered ones. (fix #1272)

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

If yes, please describe the impact and migration path for existing applications:

The PR fulfills these requirements:

Other information:

@lmiller1990 lmiller1990 requested review from lmiller1990 and removed request for eddyerburgh February 22, 2020 01:17
Copy link
Member

@lmiller1990 lmiller1990 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch. Can you remove the dist files? We don't commit them to the repository.

Other than that, looks good.

When specifying the components to stub, merge the globally registered components into the locally registered ones. (fix vuejs#1272)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Some stubbed Vuetify components can't be found with find wrapper method
2 participants