Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add typescript 5 compatible types field #2062

Merged
merged 2 commits into from Apr 11, 2023

Conversation

chriscasola
Copy link
Contributor

Typescript 5 appears to require a "types" entry in each exports entry even though there is a "types" entry at the root of the package.json

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

If yes, please describe the impact and migration path for existing applications:

The PR fulfills these requirements:

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

Other information:

Typescript 5 appears to require a "types" entry in each
exports entry even though there is a "types" entry at the
root of the package.json
@netlify
Copy link

netlify bot commented Apr 7, 2023

Deploy Preview for vue-test-utils-v1 ready!

Name Link
🔨 Latest commit 193dab8
🔍 Latest deploy log https://app.netlify.com/sites/vue-test-utils-v1/deploys/64341ba65719ba000872f2f6
😎 Deploy Preview https://deploy-preview-2062--vue-test-utils-v1.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

Copy link
Member

@lmiller1990 lmiller1990 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@lmiller1990 lmiller1990 merged commit c9b46f3 into vuejs:dev Apr 11, 2023
9 checks passed
@lmiller1990
Copy link
Member

@chriscasola chriscasola deleted the patch-1 branch April 11, 2023 12:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants