New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: find ref childComponent should be VueWrapper #267 #268

Merged

eddyerburgh merged 1 commit into vuejs:dev from aiankile:dev

Dec 15, 2017

Contributor

aiankile commented Dec 15, 2017

Fix for #267

Adjusted wrappers/wrapper.js:

find, findAll now check vm.$refs for a directly referenced Vue component, then return a VueWrapper
else standard vnode check is executed, returning Wrapper

Adjusted test mount/Wrapper/find.spec.js:

test with ChildComponent ref now tests agains VueWrapper

All tests pass, though I'm not sure if using $refs directly is ok (as it isn't used in other find-ref variants, instead going for vnodes...)


          find ref childComponent

4d170e9

vuejs#267

eddyerburgh approved these changes

View reviewed changes

eddyerburgh merged commit 256086b into vuejs:dev

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment