fix: allow plugins to be re-installed in localVue instance (fixes #406) #411
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the PR 😀 The tests are failing for Vue 2.0.x. Are you able to debug and fix? |
|
Hmm, definitely. I'll take a look. |
eddyerburgh
approved these changes
Feb 5, 2018
|
Thanks 😀 |
|
No, thank you. :) This package makes testing a dream compared to what I'm used to. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes an issue that occurs when the global Vue object has had a plugin installed to it.
In this scenario, installing the same plugin into the
localVueinstance created viacreateLocalVue()will mark the plugin as not installed and fails to reinstall it because of an additional check inside theVue.usemethod.The core source seems to be the process of cloning the original Vue object, in that plugins that are classes are of type
functioninstead of typeobject, so the original objects are passed through.