Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix classes() for svg elements #445

Merged
merged 6 commits into from
Feb 27, 2018
Merged

fix classes() for svg elements #445

Changes from 5 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
64081d9
fix classes for svg element
Feb 26, 2018
c8bc75d
fix eslint
Feb 26, 2018
4995afd
simplify fix
Feb 26, 2018
385f429
remove spaces
jeffcunat Feb 26, 2018
9730f0d
Update wrapper.js
jeffcunat Feb 26, 2018
cf9aa17
add unit test with svg element for classes
Feb 27, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion src/wrappers/wrapper.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,9 @@ export default class Wrapper implements BaseWrapper {
* Returns an Array containing all the classes on the element
*/
classes (): Array<string> {
let classes = this.element.className ? this.element.className.split(' ') : []
// works for HTML Element and SVG Element
const className = this.element.getAttribute('class')
let classes = className ? className.split(' ') : []
// Handle converting cssmodules identifiers back to the original class name
if (this.vm && this.vm.$style) {
const cssModuleIdentifiers = {}
Expand Down