Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: add max-len rule #720

Merged
merged 3 commits into from Jun 15, 2018

Conversation

eddyerburgh
Copy link
Member

No description provided.

@38elements
Copy link
Contributor

IMHO, I think it is better that code option is 120.
https://eslint.org/docs/2.0.0/rules/max-len#options

@eddyerburgh
Copy link
Member Author

I think we should use the default, prettier also uses 80 as a default. I find it easier to read 80 than 120.

Note there isn't a max-len in the test directory.

@eddyerburgh
Copy link
Member Author

We could add a limit of 120 in the test directory, which I think needs a longer limit for the spec names

@eddyerburgh eddyerburgh merged commit 2872a20 into vuejs:dev Jun 15, 2018
@eddyerburgh eddyerburgh deleted the add-max-line-length-rule branch June 15, 2018 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants